Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add exclusive fullscreen mode with Dock and Menu disabled. #68257

Merged
merged 1 commit into from Nov 14, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 4, 2022

Fixes #68254

@akien-mga akien-mga modified the milestones: 4.x, 4.0 Nov 4, 2022
@akien-mga
Copy link
Member

Would be interesting to also have this implemented for 3.x somehow (not sure how since we don't have exclusive fullscreen there).

@bruvzg
Copy link
Member Author

bruvzg commented Nov 4, 2022

Would be interesting to also have this implemented for 3.x somehow (not sure how since we don't have exclusive fullscreen there).

I guess 3.x always use exclusive fs on Windows, so it probably should always do it on macOS as well (but I would keep window title button to work without setting presentation mode, since it's more expected behavior).

@bruvzg
Copy link
Member Author

bruvzg commented Nov 4, 2022

Actually not fully sure about setting NSApplicationPresentationDisableProcessSwitching, it's disabling Exposé hot corners (which is probably as desired as disabling Dock and Menu), but also disabling switching app with Cmd+Tab (which night be too much, Force Quit is still accessible, so it's not locking up the system).

@akien-mga
Copy link
Member

How do other non-Godot games behave typically on macOS for this?

@bruvzg
Copy link
Member Author

bruvzg commented Nov 14, 2022

How do other non-Godot games behave typically on macOS for this?

Seems like most of the games I have tested do not block Expose, so I have removed it as well.

@bruvzg bruvzg changed the title [macOS] Add exclusive fullscreen mode with Dock, Menu and Exposé disabled. [macOS] Add exclusive fullscreen mode with Dock and Menu disabled. Nov 14, 2022
@akien-mga akien-mga merged commit 193f070 into godotengine:master Nov 14, 2022
@bruvzg bruvzg deleted the macos_ex_fs branch November 14, 2022 10:14
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX export fullscreen mode inconsistent due to missing info.plist entries
2 participants