Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable code font ligatures by default in the editor #68571

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 12, 2022

In the interest of principle of least astonishment, having ligatures disabled by default is probably better.

This closes #63865.

@Calinou Calinou force-pushed the editor-default-disable-code-font-ligatures branch from afaf84d to 5456dbc Compare November 12, 2022 21:37
@Calinou Calinou force-pushed the editor-default-disable-code-font-ligatures branch from 5456dbc to 11842eb Compare November 12, 2022 21:38
@Calinou Calinou requested a review from a team as a code owner November 12, 2022 21:38
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, having ligatures disabled by default is probably the best (at least for now).

@akien-mga akien-mga merged commit 2abfa9e into godotengine:master Nov 13, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the editor-default-disable-code-font-ligatures branch February 9, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code ligatures shouldn't apply on literal strings
4 participants