Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Don't use the NIL address to hold return value of functions #71107

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

vnen
Copy link
Member

@vnen vnen commented Jan 9, 2023

This prevents that the NIL address is filled with another value, which causes problems for some instructions that read from NIL.

This is still a bit of a flimsy solution, we need to find a way to disambiguate the NIL target (i.e. discard the return value) and the NIL source (i.e. use a Variant of type NIL). I thought of some ways to do it but any of those would take a while to implement and test, so it's best if done later.

Fix #70964
Fix #70936
Fix #70953

This prevents that the NIL address is filled with another value, which
causes problems for some instructions that read from NIL.
@vnen vnen added this to the 4.0 milestone Jan 9, 2023
@vnen vnen requested a review from a team as a code owner January 9, 2023 12:25
@vnen vnen added the regression label Jan 9, 2023
@vnen
Copy link
Member Author

vnen commented Jan 9, 2023

Added a fix to #70953 which is also a regression introduced in my other PR.

@akien-mga
Copy link
Member

Added a fix to #70953 which is also a regression introduced in my other PR.

From that PR, you also have #71065 to handle I believe.

@akien-mga akien-mga merged commit df952a3 into godotengine:master Jan 9, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment