-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SceneImportSettings perf issues #71691
Fix SceneImportSettings perf issues #71691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a suggestion that I think helps the codestyle/clarity. In terms of content, this change makes sense to me. We definitely do not want to be creating a collider every tick
6f110a1
to
c608e79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, but I am not expert in the importer, so it would be nice to have a review from someone else more knowledgeable as well.
c608e79
to
b95219e
Compare
Thanks! |
Scene Importer was generating collider mesh at every tick when
Physics
options was enabled, this makes it only do it when changing settings related toINTERNAL_IMPORT_CATEGORY_MESH_3D_NODE
.Honestly I am not 100% confident the actual implementation is how something like this would be done in the project but I couldn't find some clear pattern to replicate.
This closes #68301