Prevent cache corruption when saving resources in the editor #74615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not able to test it but the idea is pause the editor until imports are finished? |
This is not related to imports, at least not directly. This is about saving Godot resources from inside of the editor, which currently triggers a rescan of the resource file immediately upon file creation. This PR delays it until after all the saving procedures have been performed. Nothing is paused, as this happens in milliseconds. |
|
That logically makes sense. 👍 |
akien-mga
approved these changes
Mar 9, 2023
|
Thanks! |
|
Cherry-picked for 4.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74069.
See my comment there for what's going on and how this is not a GDScript module issue. Basically, I make sure that the editor doesn't handle resource saving too soon and that in turn prevents all of the following issues. This is a hack, and something that should be better addressed when we are going to rework
EditorNode, but it prevents this crash for now, and it should also prevent some of those "Another resource is loaded from path" errors sometimes, I guess.The change in GDScript is just cosmetic, a remnant of my investigation. But I did feel it made the method a bit clearer, so I kept it.