Add recovery_as_collision to extension binding of _body_test_motion
#74707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Mar 10, 2023
akien-mga
approved these changes
Mar 10, 2023
|
Thanks! |
This was referenced Apr 19, 2023
|
I removed the cherry-pick label because this PR breaks compatibility for extensions, and there isn't a strong reason at the moment to justify that for a patch release. GDExtension is still in a beta state, but we should still preserve BC where possible. Jolt seems to be still very much in development, so it probably makes sense for it to target 4.1 as the first stable release to support. We can reconsider this later if there is a push for this to be included in 4.0 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when implementing support for
PhysicsServer3D::body_test_motionfrom a GDExtension, therecovery_as_collisionfield ofPhysicsServer3D::MotionParametersis not passed on as a parameter toPhysicsServer3DExtension::_body_test_motion, making it impossible to implement full support for things likePhysicsBody3D.move_and_collideorPhysicsBody3D.test_move.This PR adds that parameter.