Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix InputEventConfigurationDialog modifies original event #74858

Merged
merged 1 commit into from Mar 15, 2023
Merged

Fix InputEventConfigurationDialog modifies original event #74858

merged 1 commit into from Mar 15, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Mar 13, 2023 •
edited

The bug is due to swapped arguments.

godot/editor/input_event_configuration_dialog.h

Line 102 in 550a779

void _set_event(const Ref<InputEvent> &p_event, const Ref<InputEvent> &p_original_event, bool p_update_input_list_selection = true);

godot/editor/input_event_configuration_dialog.cpp

Line 550 in 550a779

_set_event(p_event, p_event->duplicate());

Closes #74389.

@YuriSizov YuriSizov added this to the 4.1 milestone Mar 13, 2023
@YuriSizov YuriSizov merged commit f2eb40d into godotengine:master Mar 15, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@dalexeev dalexeev deleted the fix-input-event-dialog branch March 15, 2023 12:35
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@EricEzaM EricEzaM Awaiting requested review from EricEzaM

Assignees
No one assigned
Labels
bug topic:editor topic:input
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

Editor Shortcuts reset after restarting Godot
3 participants
@dalexeev @YuriSizov @bruvzg