Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix descriptions not showing for theme properties #75559

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix descriptions not showing for theme properties #75559

merged 1 commit into from
Apr 2, 2023

Conversation

ajreckof
Copy link
Member

@ajreckof ajreckof commented Apr 1, 2023 •
edited by YuriSizov
Loading

Supersedes #75552

@ajreckof ajreckof force-pushed the Fix-descriptions-not-showing-for-theme-properties branch from e22aa5b to 9594050 Compare April 1, 2023 11:25
@YuriSizov YuriSizov added this to the 4.1 milestone Apr 1, 2023
@ajreckof ajreckof force-pushed the Fix-descriptions-not-showing-for-theme-properties branch from 9594050 to 2904bb5 Compare April 1, 2023 11:48
@YuriSizov
Copy link
Contributor

YuriSizov commented Apr 1, 2023 •
edited
Loading

The trailing underscore from my suggestion was meaningful, as it ensures this is not the entire name.

@ajreckof ajreckof force-pushed the Fix-descriptions-not-showing-for-theme-properties branch from 2904bb5 to 14140eb Compare April 1, 2023 11:57
@ajreckof
Copy link
Member Author

ajreckof commented Apr 1, 2023

Sorry I didn't see it. it has been corrected

@akien-mga akien-mga merged commit 726c3c1 into godotengine:master Apr 2, 2023
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.3.

@ajreckof ajreckof deleted the Fix-descriptions-not-showing-for-theme-properties branch May 1, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:gui
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ajreckof @YuriSizov @akien-mga @KoBeWi