Fix for POSITION fragment shader var in 2.1 stable. #7565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumihoclub
changed the title
kumihoclub
changed the title
bojidar-bg
reviewed
Jan 17, 2017
| @@ -818,7 +818,8 @@ ShaderCompilerGLES2::ShaderCompilerGLES2() { | |||
| //mode_replace_table[ShaderLanguage::SHADER_MATERIAL_FRAGMENT]["POSITION"]="IN_POSITION"; | |||
| mode_replace_table[ShaderLanguage::SHADER_MATERIAL_FRAGMENT]["NORMAL"]="normal"; | |||
| mode_replace_table[ShaderLanguage::SHADER_MATERIAL_FRAGMENT]["TANGENT"]="tangent"; | |||
| mode_replace_table[ShaderLanguage::SHADER_MATERIAL_FRAGMENT]["POSITION"]="gl_Position"; | |||
| //mode_replace_table[ShaderLanguage::SHADER_MATERIAL_FRAGMENT]["POSITION"]="gl_Position"; | |||
There was a problem hiding this comment.
Why keep it as a comment though?
|
CC @RandomShaper, my new shader expert :p |
|
Calling me an expert is very kind of you. Not too accurate, though. :) Anyway, I've tested it with 2D and 3D shaders and it works nice. The only thing I'd say is that z and w are meaningless for 2D so it would be better to have a vec2 POSITION for 2D with only gl_FragCoord.xy mapped to it. |
Would you maybe make a PR for that, or should we merge the current one as is? |
|
Working on it. |
|
Have a look at #7969. |
|
Superseded by #7969. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issues related to the POSITION var in fragment shaders.
#3226
#7416