Add missing stdint.h includes for GCC 13+
#77949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:buildsystem
cherrypick:3.x
akien-mga
changed the title
stdint.h includes for GCC 13+
|
Cherry-picked for 4.0.4. |
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.3. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77927.
Thanks @germanbv for finding and documenting the fixes. FYI, you could have made a PR with those changes directly :)
That being said, we're a bit peculiar with how we handle modifications to thirdparty code vendored in Godot, so I went ahead and did the PR myself.
Added patch files for v-hacd (the issue seems fixed upstream, but we're on an outdated version so making the difference clear is still important) and openxr (PR'ed the fix upstream, might be included in the next release if accepted: KhronosGroup/OpenXR-SDK-Source#406). It's already fixed upstream in glslang so I didn't add a patch file, it will be included next time we update (it's included in #77898 which will supersede this for 4.1, but we still need the patch for 4.0 and earlier).