Copy texture filter/repeat modes when replacing a texture in the GL Compatibility backend #78287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #78228
When a GradientTexture1D is updated we use the
texture_replace()function to place the contents of the new texture into the resource referenced by the old RID. Thecopy_from()copies all the Texture state except for the filter/repeat modes. This lead to a situation where the gl_texture's state got out of sync with the Texture referenced by the RID. This change ensures that we copy over all data from the new_texture so that the filter/repeat can get properly updated at draw time.