Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to swap default Alt+scroll zooming behavior in 2D editor #78451

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

alula
Copy link
Contributor

@alula alula commented Jun 20, 2023

No description provided.

@alula alula requested a review from a team as a code owner June 20, 2023 01:25
@Chaosus Chaosus added this to the 4.2 milestone Jun 20, 2023
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (on top of master 329652b), it works. Code and documentation look good to me.

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

For the record the CI error is not related to this issue, a new build attempt should hopefully solve it.

Update doc/classes/EditorSettings.xml

Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@alula
Copy link
Contributor Author

alula commented Jun 21, 2023

done

@YuriSizov YuriSizov merged commit 5f23b8b into godotengine:master Jul 14, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

YuriSizov commented Jul 14, 2023

Thanks! And congrats on your first merged Godot PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants