Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero-sized WorkerThreadPool not processing group tasks #78845

Merged
merged 1 commit into from Jul 7, 2023
Merged

Fix zero-sized WorkerThreadPool not processing group tasks #78845

merged 1 commit into from Jul 7, 2023

Conversation

RandomShaper
Copy link
Member

With zero threads, tasks are processed on the calling thread, one at a time. However, for group tasks, the logic needed a little tweak.

Fixes #77131.

@RandomShaper RandomShaper added this to the 4.2 milestone Jun 29, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner June 29, 2023 17:46
@RandomShaper RandomShaper added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 4, 2023
@akien-mga akien-mga merged commit 862a284 into godotengine:master Jul 7, 2023
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_wtp_zero_batch_lazy branch July 10, 2023 13:42
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Scene testruns with threading/worker_pool/max_threads set to 0 get stuck after recent WorkerThreadPool changes
4 participants
@RandomShaper @akien-mga @YuriSizov @clayjohn