Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to center image when loading particle emission mask #78944

Merged
merged 1 commit into from Jul 27, 2023

Conversation

bgie
Copy link
Contributor

@bgie bgie commented Jul 2, 2023

I messed up pull request 78583 by working on master and some rebasing/resetting and force pushing. This is a recreation of that pull request with a change as commented by @KoBeWi

The dialog now looks like:
Screenshot 2023-07-02 121740

Recap: when loading an image to use as a particle emission mask, the option to center the image is now available. The centering is applied when generating the mask, so no extra runtime cost is involved.

Fixes #16411

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Jul 10, 2023
@YuriSizov YuriSizov requested a review from a team July 14, 2023 17:23
@YuriSizov YuriSizov changed the title Added option to center image when loading particle emission mask Add option to center image when loading particle emission mask Jul 14, 2023
@YuriSizov YuriSizov requested a review from QbieShay July 27, 2023 12:31
@QbieShay
Copy link
Contributor

This is going to have a minor overlap with #refactor particl 's emitter offset but definitely a great improvement. Thank you!

@YuriSizov YuriSizov merged commit 4aae6d3 into godotengine:master Jul 27, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@Arecher
Copy link

Arecher commented Sep 28, 2023

Is there are chance this can get cherry-picked for 3.x? Would be a very welcome addition!

@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2D Particle Emission Mask is offset
7 participants