Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the fallback logic of OS::shell_show_in_file_manager. #79087

Conversation

Daylily-Zeleen
Copy link
Contributor

@Daylily-Zeleen Daylily-Zeleen commented Jul 6, 2023

Fix #79044 and update document.

Still need someone to implements OS::shell_show_in_file_manager on other platiforms.

@Daylily-Zeleen Daylily-Zeleen marked this pull request as ready for review July 6, 2023 05:19
@Daylily-Zeleen Daylily-Zeleen requested review from a team as code owners July 6, 2023 05:19
@Daylily-Zeleen Daylily-Zeleen changed the title Fixed the fallback logic of OS::shell_show_in_file_manager. Fix the fallback logic of OS::shell_show_in_file_manager. Jul 6, 2023
@akien-mga akien-mga added bug platform:linuxbsd topic:porting cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 6, 2023
@akien-mga akien-mga added this to the 4.2 milestone Jul 6, 2023
@akien-mga akien-mga merged commit 8a84a39 into godotengine:master Jul 7, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jul 10, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants