Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AnimationNodeTransition with negative time scale #79403

Merged
merged 1 commit into from Jul 24, 2023
Merged

Fix AnimationNodeTransition with negative time scale #79403

merged 1 commit into from Jul 24, 2023

Conversation

TokageItLab
Copy link
Member

Fixes #77535.

Absolute values should be used to calculate xfade times.

@TokageItLab TokageItLab added bug topic:animation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Jul 12, 2023
@TokageItLab TokageItLab added this to the 4.2 milestone Jul 12, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner July 12, 2023 23:40
@TokageItLab TokageItLab changed the title Fix NodeTransition with negative time scale Fix AnimationNodeTransition with negative time scale Jul 12, 2023
adamscott
adamscott approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the animation/assets-pipeline team meeting! It will be important to check if this fix affects looping, though.

@YuriSizov YuriSizov merged commit 752b89d into godotengine:master Jul 24, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@TokageItLab TokageItLab deleted the fix-negative-timescale-transition branch February 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Problem with Animations on BlendTrees and Negative TimeScales
3 participants
@TokageItLab @YuriSizov @adamscott