Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect virtual function in VideoStream.set_paused #79710

Merged
merged 1 commit into from Aug 1, 2023
Merged

Fix incorrect virtual function in VideoStream.set_paused #79710

merged 1 commit into from Aug 1, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added this to the 4.2 milestone Jul 20, 2023
@AThousandShips AThousandShips requested a review from a team July 31, 2023 16:51
@YuriSizov YuriSizov merged commit c9aa213 into godotengine:master Aug 1, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips AThousandShips deleted the video_play branch August 1, 2023 15:56
@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@AThousandShips
Copy link
Member Author

Realized that this error existed in 4.1 as well so marked for cherry picking

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:core topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

VideoStream calls wrong virtual function on set_paused
3 participants
@AThousandShips @YuriSizov @RandomShaper