Add a nearest-neighbor scaling option to Viewport's Scaling 3D Mode property

[Calinou]

This is useful for 3D games with a pixel art appearance, or when using a resolution scale of 0.5 to improve performance without compromising crispness too much when not using FSR 1.0.

The property hints now allow decreasing the scale further to accomodate for pixel art use cases, as well as increased precision in the value (useful for a scale of 0.3333).

This is supported in all rendering methods.

I've made sure that effects relying on bilinear filtering to look correct (such as glow and depth of field) still work correctly. No Vulkan validation errors are reported when running with --gpu-validation on either rendering method.

Testing project: test_scaling_3d_nearest.zip

• This closes Add a nearest-neighbor scaling option to Viewport's Scaling 3D Mode property godot-proposals#4697.

Preview

Bilinear

AMD FSR 1.0

Nearest (this PR)

[Sauermann]

I 'm not familiar with RenderingServer, but would this help with #72548?

[Calinou]

I 'm not familiar with RenderingServer, but would this help with #72548?

Not entirely, as the use case from that issue is to scale both the 2D and 3D rendering. We only have scaling_3d_scale, not scaling_2d_scale 🙂

[Calinou]

Rebased and tested again, it works as expected.

[akien-mga]

CC @DarioSamo

[DarioSamo]

Code looks fine to me, although I'm not the biggest fan of nearest due to the shimmering on uneven pixel scales like the documentation points out. It makes sense to provide the option regardless.

For games that actually want to preserve the pixel art aspect, I'm a bigger fan of filters like these, although they're not free performance wise compared to nearest.

But like I said this is one case where the more options the better, as nearest will work properly if the developer makes sure the resolution scale is accurate.

[mrjustaguy]

What happens if you set resolution scale above 1 with nearest scaling? such as 2?
In such scenarios I can see it breaking and might be better to check for that case and revert to bilinear

[Calinou]

What happens if you set resolution scale above 1 with nearest scaling? such as 2? In such scenarios I can see it breaking and might be better to check for that case and revert to bilinear

It reverts to bilinear automatically if resolution scale is above 1.0: https://github.com/godotengine/godot/pull/79731/files#diff-48a2a86e07288d8aa1500bb912bd1d7e51477df56d3a0660648b2382c4a79a4bR136-R139

[squishyu]

Any updates on merging this? Just saw v4.3 is almost in beta, would be nice to finally add this.

[Calinou]

Rebased and tested again, it works as expected in Forward+ and Mobile.

Note that 3D scaling support was implemented in the Compatibility rendering method in #83976, but I haven't implemented nearest-neighbor filtering there yet.

[Calinou]

It's implemented in Compatibility now:

Bilinear

Nearest

[AThousandShips]

@GlitchedPolygons Please don't bump without contributing significant new information. Use the 👍 reaction button on the first post instead.

Edit: Add your reaction to the main post at the very top, or add your vote here (do not comment unless you have new information there either):

• Add a nearest-neighbor scaling option to Viewport's Scaling 3D Mode property godot-proposals#4697

[GlitchedPolygons]

@GlitchedPolygons Please don't bump without contributing significant new information. Use the 👍 reaction button on the first post instead.

sry, I'm new here and I got excited with this PR :)

is there anywhere else where I can add my vote for this?