Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp Volumetric Fog Length property to prevent rendering issues #80485

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Aug 10, 2023

This creates visual artifacts similar to what's seen in #78500.

A length of 0 units doesn't make sense anyway.

A length of 0 units doesn't make sense anyway.
@Calinou Calinou added bug topic:editor topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 10, 2023
@Calinou Calinou added this to the 4.2 milestone Aug 10, 2023
@Saul2022
Copy link

cool also it would be cool to also clamp density or have a warning to avoid some issues that causes black and white square on the screen.

@Calinou
Copy link
Member Author

Calinou commented Aug 10, 2023

cool also it would be cool to also clamp density or have a warning to avoid some issues that causes black and white square on the screen.

I didn't encounter similar issues with high density, even if I set Density to 200 while having Length set to 0.01. Could you link to an issue with Density specifically?

@akien-mga akien-mga merged commit a8edbcf into godotengine:master Aug 11, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Saul2022
Copy link

I didn't encounter similar issues with high density, even if I set Density to 200 while having Length set to 0.01. Could you link to an issue with Density specifically?

After testing some bit i was not able to reproduce that white and black combining low density with 0 lenght, and the black screen is fixed by this pr, so i guess it more or less fixed, sorry for my confussion.

@Calinou Calinou deleted the volumetric-fog-clamp-length branch August 16, 2023 12:56
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants