Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextServer] Fix system font fallback and caret/selection behavior for composite characters. #80650

Merged
merged 1 commit into from Aug 18, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 15, 2023

  • Fixes system font fallback for composite characters.
  • Fixes caret/selection behavior for composite characters, composite characters (e.g, ❤️‍🔥) behave as one character, and graphemes of non-composite (e.g., ffi) characters do not.
Screen.Recording.2023-08-15.at.11.40.31.mov

Fixes #80621

@bruvzg bruvzg added this to the 4.2 milestone Aug 15, 2023
@bruvzg bruvzg marked this pull request as ready for review August 15, 2023 11:46
@bruvzg bruvzg requested review from a team as code owners August 15, 2023 11:46
@Koyper
Copy link
Contributor

Koyper commented Aug 18, 2023

Fantastic!

@akien-mga akien-mga merged commit b51ee8b into godotengine:master Aug 18, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain unicode surrogate pair emoji are not recognized
3 participants