Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiplier to fix color in Mobile renderer #80663

Closed
wants to merge 1 commit into from

Conversation

Vennnot
Copy link

@Vennnot Vennnot commented Aug 15, 2023

Relevant Issue

I carried out the changes as stated in the original issue. Please let me know if this is not the best solution. I am a novice with C++ and even more so in a project such as Godot.

@Vennnot Vennnot requested a review from a team as a code owner August 15, 2023 16:45
@AThousandShips
Copy link
Member

Thank you for contributing!

You've included an incorrect file, you need to remove it

@Vennnot
Copy link
Author

Vennnot commented Aug 15, 2023

Whoops, my bad! I still don't know how to handle git log 😄

I've deleted the file 👍

@AThousandShips
Copy link
Member

Please squash your commits into one, see here

@Vennnot
Copy link
Author

Vennnot commented Aug 15, 2023

Should now be one commit!

Learning more and more

@AThousandShips
Copy link
Member

Isn't it exciting? Git can be confusing at the start but it becomes second nature after a while

@Vennnot
Copy link
Author

Vennnot commented Aug 15, 2023

I hope so. I've always used GUIs for years but this is my first time doing it from console. Strange new world.

I still can't run Godot in CLion since it can't find Scons for some reason. But we're getting there!

@akien-mga
Copy link
Member

Superseded by #80933.
Thanks for the contribution nonetheless!

@akien-mga akien-mga closed this Aug 28, 2023
@AThousandShips AThousandShips removed this from the 4.x milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear color is lighter on mobile renderer
3 participants