Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear color on mobile renderer #80933

Merged
merged 1 commit into from Aug 31, 2023
Merged

Fix clear color on mobile renderer #80933

merged 1 commit into from Aug 31, 2023

Conversation

ChibiDenDen
Copy link
Contributor

@ChibiDenDen ChibiDenDen commented Aug 23, 2023 •
edited by AThousandShips

@ChibiDenDen ChibiDenDen requested a review from a team as a code owner August 23, 2023 16:21
@AThousandShips

This comment was marked as outdated.

Sign in to view
@AThousandShips AThousandShips added this to the 4.x milestone Aug 23, 2023
@AThousandShips AThousandShips mentioned this pull request Aug 15, 2023
Closed
@fire fire changed the title fix clear color on mobile renderer Fix clear color on mobile renderer Aug 23, 2023
clayjohn
clayjohn reviewed Aug 26, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks mostly good, but see my comment

servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Aug 28, 2023
clayjohn
clayjohn approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@clayjohn clayjohn added cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release and removed cherrypick:4.0 labels Aug 30, 2023
@clayjohn
Copy link
Member

Actually just cherrypick for 4.1 I think. As this is a pretty clear visual change

@akien-mga akien-mga merged commit aa9f358 into godotengine:master Aug 31, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Nov 9, 2023
Closed
@YuriSizov
Copy link
Contributor

Actually just cherrypick for 4.1 I think.

@clayjohn Changes here kind of build upon #79876. Should we also pick that one? Or I can fix the conflicts manually. Or we can forgo picking completely at this point.

@clayjohn
Copy link
Member

Let's just cherrypick #79876 as well.

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Clear color is lighter on mobile renderer
5 participants
@ChibiDenDen @AThousandShips @clayjohn @akien-mga @YuriSizov