Implement conversion from CPUParticles to GPUParticles (3D/2D)
#80779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
cpuparticles_converter
branch
from
96d9aba
to
7fcb91f
Compare
Calinou
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Tested locally (rebased on top of master 5444afa), it works as expected.
In 3D, some particles appear too dark after being converted to from GPUParticles to CPUParticles (not introduced in this PR), so that's why they appear brighter when converted back to GPUParticles.
Testing projects: https://github.com/godotengine/godot-demo-projects/tree/master/2d/particles and https://github.com/godotengine/godot-demo-projects/tree/master/3d/particles
2D
| CPUParticles | Converted to GPUParticles |
|---|---|
3D
| CPUParticles | Converted to GPUParticles |
|---|---|
QbieShay
approved these changes
Aug 21, 2023
|
Calinou was faster than me, LTGM! Thank you a lot!! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a conversion option from CPUParticles2D/CPUParticles3D -> GPUParticles2D/3D. Closes godotengine/godot-proposals#2997.