Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextServer] Store extra spacing of individual font variations. #80954

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[TextServer] Store extra spacing of individual font variations. #80954

merged 1 commit into from
Aug 28, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 24, 2023

Fixes #80907

Screenshot 2023-08-24 at 11 50 27

@bruvzg bruvzg added this to the 4.2 milestone Aug 24, 2023
@bruvzg bruvzg marked this pull request as ready for review August 26, 2023 19:41
@bruvzg bruvzg requested review from a team as code owners August 26, 2023 19:41
akien-mga
akien-mga approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wish we already had structs support for passing this kind of data instead of relying on 4 optional int arguments.

@akien-mga akien-mga merged commit ba10896 into godotengine:master Aug 28, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title [Text Server] Store extra spacing of individual font variations. [TextServer] Store extra spacing of individual font variations. Sep 5, 2023
@matheusmdx matheusmdx mentioned this pull request Sep 22, 2023
Closed
@bruvzg bruvzg mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Extra Spacing in a nested FontVariation does not work
2 participants
@bruvzg @akien-mga