Display time of last save in the unsaved changes confirmation editor dialog #80976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That sounds really useful! Just one thing: I don't really like a lot the fact that now the popup becomes even wider. What if the time of last save would be put as a new line altogether? |
dalexeev
reviewed
Aug 25, 2023
Calinou
force-pushed
the
editor-unsaved-changes-display-last-save-time
branch
from
3ff017d
to
427abf3
Compare
Done, see OP for updated screenshot 🙂 |
akien-mga
reviewed
Aug 30, 2023
…dialog When multitasking, this makes it clearer whether closing a window with unsaved changes is potentially dangerous or not.
Calinou
force-pushed
the
editor-unsaved-changes-display-last-save-time
branch
from
427abf3
to
3ba0316
Compare
akien-mga
approved these changes
Aug 31, 2023
|
Thanks! |
|
The displayed time is wrong, it should be tracked per scene. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multitasking, this makes it clearer whether closing a window with unsaved changes is potentially dangerous or not.
This is inspired by various games which display such a message when quitting, but I've seen various apps do it as well (I can't remember exactly which ones though).
Preview