[Windows] Fix not applying NVIDIA profile to new executables #81251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
cherrypick:4.1
akien-mga
added
the
cherrypick:3.x
aitorciki
force-pushed
the
nvidia-profile-multiapp
branch
from
5218140
to
f47fee6
Compare
An NVIDIA profile is applied to the current executable to disable threaded OpenGL optimizations on Windows (see godotengine#71472). But because the application is only added to the profile upon the profile creation, newer executables won't be added to the profile (e.g. if the profile is created on first launch of Godot_v4.1-stable_win64.exe, when users update the editor and launch Godot_v4.2-stable_win64.exe, the profile will never be applied to this new executable). This patch fixes that scenario by splitting creating the profile (if it doesn't exist) and adding the application (if it doesn't have a profile applied) into two separate steps. Applications that have been manually added to a different profile aren't overriden to avoid confusing users who know what they're doing.
aitorciki
force-pushed
the
nvidia-profile-multiapp
branch
from
f47fee6
to
6263774
Compare
Calinou
approved these changes
Sep 22, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An NVIDIA profile is applied to the current executable to disable threaded OpenGL optimizations on Windows (see #71472). But because the application is only added to the profile upon the profile creation, newer executables won't be added to the profile (e.g. if the profile is created on first launch of
Godot_v4.1-stable_win64.exe, when users update the editor and launchGodot_v4.2-stable_win64.exe, the profile will never be applied to this new executable).This patch fixes that scenario by splitting creating the profile (if it doesn't exist) and adding the application (if it doesn't have a profile applied) into two separate steps.
Applications that have been manually added to a different profile aren't overriden to avoid confusing users who know what they're doing.