C#: Move bindings_generator warnings to .editorconfig
#81703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
reviewed
Sep 16, 2023
Repiteo
force-pushed
the
c#-binding-warnings-to-editorconfig
branch
from
89e6fb6
to
e43b63a
Compare
raulsntos
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
I think this is fine, we should try to document the generated code properly so we can remove these suppressions in the future.
Note that this will also suppress the warnings for the GD_extensions.cs and NativeCalls.cs files that previously weren't suppressing them.
|
Thanks! |
YuriSizov
changed the title
bindings_generator warnings to .editorconfigbindings_generator warnings to .editorconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the warning handlers for
CS1591andCS1573from the binding generator's stringbuilder to the GodotSharp.editorconfigfile. The handlers in the binding generator predate the creation of this file, and the only section that exists is for the "Generated" folders so this makes for a seamless additionBeyond that, the only change made is appendingReverted: unsure of the full implications on analyzers if this changedgenerated_code = trueto the generator config, which makes the folder & its contents explicitly recognized as generated for any IDE/tool that supports it