Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save to file failed when slicing 3d animation #82300

Conversation

jsjtxietian
Copy link
Contributor

Fixes #81955

A typo made a path string into a bool, so the save failed.

Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clear cut bug fix, I think we should merge. LGTM 👍

@SaracenOne
Copy link
Member

I'll leave this approved for consideration, but I would actually strongly recommend merging this PR instead, since they both fix the same bug, but they also conflict and this PR has more comprehensive fixes #83036

@YuriSizov
Copy link
Contributor

Superseded by #83036.

@YuriSizov YuriSizov closed this Nov 3, 2023
@YuriSizov YuriSizov removed this from the 4.2 milestone Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicing 3D animation in .glb and .blend file import breaks Save to File setting
4 participants