Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix borderless mode on macOS 13.6+. #82357

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 26, 2023

Seems like the behavior changed in macOS 13.6 and 14.x.

Fixes #82349

@bruvzg bruvzg added this to the 4.2 milestone Sep 26, 2023
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 26, 2023
@bruvzg bruvzg marked this pull request as ready for review September 26, 2023 10:14
@bruvzg bruvzg requested a review from a team as a code owner September 26, 2023 10:14
@BrixsterPlanet
Copy link

Does this need a check for older macOS versions, or does this fix the borderless behavior across all versions?

@bruvzg
Copy link
Member Author

bruvzg commented Sep 27, 2023

Does this need a check for older macOS versions, or does this fix the borderless behavior across all versions?

Version check is unnecessary, it should work on older versions as well.

@akien-mga akien-mga merged commit 124f898 into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing Window.borderless property causes main window to vanish on macOS
4 participants