Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building without GDScript #82985

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix building without GDScript #82985

merged 1 commit into from
Oct 9, 2023

Conversation

jackwilsdon
Copy link
Contributor

This PR fixes building with module_gdscript_enabled=no, which previously failed due to references to the module.

Fixes #82231

@jackwilsdon jackwilsdon requested a review from a team as a code owner October 8, 2023 00:31
@jackwilsdon jackwilsdon mentioned this pull request Oct 8, 2023
Closed
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 8, 2023
@akien-mga akien-mga merged commit 0b11010 into godotengine:master Oct 9, 2023
15 checks passed
@jackwilsdon jackwilsdon deleted the build-without-gdscript branch October 9, 2023 13:43
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Cannot compile godot with non standard build flags(probably problem with disabling GDScript)
4 participants
@jackwilsdon @akien-mga @RandomShaper @AThousandShips