Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Free dialogs when exiting the editor #83809

Merged
merged 1 commit into from
Oct 30, 2023
Merged

C#: Free dialogs when exiting the editor #83809

merged 1 commit into from
Oct 30, 2023

Conversation

raulsntos
Copy link
Member

In the previously linked PR I unparented the dialogs to fix the Transient parent has another exclusive child error. This means the dialogs aren't freed when exiting the editor. This PR now frees those dialogs on _exit_tree which should prevent the leaks reported in the issue linked above.

@raulsntos raulsntos added this to the 4.2 milestone Oct 23, 2023
@raulsntos raulsntos requested a review from a team as a code owner October 23, 2023 01:14
@raulsntos raulsntos mentioned this pull request Oct 23, 2023
Closed
@akien-mga akien-mga merged commit 6794155 into godotengine:master Oct 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/free-dialogs branch October 30, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Regression: .NET editor build 4.2-beta2 is leaking resources at exit
2 participants
@raulsntos @akien-mga