Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and clarify texture filtering documentation #83907

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Improve and clarify texture filtering documentation #83907

merged 1 commit into from
Dec 4, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 24, 2023

  • Mention the Use Nearest Mipmap Filter project setting.
  • Fix nearest mipmap claiming to always use bilinear filtering (it uses trilinear filtering by default, like linear mipmap).

@Calinou Calinou requested a review from a team as a code owner October 24, 2023 21:35
@Calinou Calinou mentioned this pull request Oct 24, 2023
Open
@Calinou Calinou added bug enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 24, 2023
@Calinou Calinou added this to the 4.2 milestone Oct 24, 2023
@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Nov 13, 2023
@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 13, 2023
@Calinou
Improve and clarify texture filtering documentation
47cadda 
- Mention the Use Nearest Mipmap Filter project setting.
- Fix nearest mipmap claiming to always use bilinear filtering
  (it uses trilinear filtering by default, like linear mipmap).
clayjohn
clayjohn approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I only read through the filters for BasteMaterial3D, I trust that they are the same in all 5 classes.

@akien-mga akien-mga merged commit 628af13 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Calinou @akien-mga @YuriSizov @clayjohn