Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow MeshInstance3D-inherited nodes in MultiMesh Populate Surface dialog #84933

Merged
merged 1 commit into from Dec 4, 2023
Merged

Only allow MeshInstance3D-inherited nodes in MultiMesh Populate Surface dialog #84933

merged 1 commit into from Dec 4, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 15, 2023 •
edited

@Calinou Calinou added bug topic:editor topic:3d cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 15, 2023
@Calinou Calinou added this to the 4.3 milestone Nov 15, 2023
@AThousandShips AThousandShips requested a review from a team November 15, 2023 11:51
smix8
smix8 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@smix8 smix8 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as the EditorPlugin throws an error with anything else selected other than a MeshInstance3D with a valid Mesh.

@akien-mga akien-mga merged commit 764e468 into godotengine:master Dec 4, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.1.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smix8 smix8 smix8 approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

"Target Surface:" and "Source Mesh:" should only accept nodes that inherit Node3D
4 participants
@Calinou @akien-mga @YuriSizov @smix8