Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix looped animation seek end. #85186

Closed
wants to merge 1 commit into from

Conversation

rakkarage
Copy link
Contributor

Closes: #37343

Thanks.

@rakkarage rakkarage requested a review from a team as a code owner November 21, 2023 17:40
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 21, 2023
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is not good way since this should apply to only editor. Also this causes a regression where the loop does not occur when the script seeks beyond the animation time.

The correct way should be to fix the time when the timeline seek to the end in the editor, or using TOOL_ENABLED with some of the checking for editor seeking.

@TokageItLab TokageItLab removed this from the 4.3 milestone Nov 21, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Nov 21, 2023
@rakkarage
Copy link
Contributor Author

This is not a good response.
It works from code and editor.

If you seek to a specific time from code or Editor u wanna skip modulus I think. Otherwise seekToEnd = seekToStart. You could never seek to end from code?
The animation also plays fine after seeking past end from code. But i suspect it not really go past, like editor...

Editor does not allow seek past end, anyway.
What would u like to happen when seek past end in your code? Cannot replicate regression.

@YuriSizov
Copy link
Contributor

YuriSizov commented Nov 22, 2023

Superseded by the linked PR. Thanks for your contribution nonetheless! If there is still a runtime issue worth addressing, I guess it would be good to document it with a new issue report and discuss the solution further.

Edit: Don't mind the accidental reopening below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Looped animation uses value from the beginning when it shouldn't
4 participants