-
-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for UndoRedo
#85434
Add unit tests for UndoRedo
#85434
Conversation
You seem to have missed some of your code, or was this meant to be a draft? |
ae72631
to
470c3db
Compare
Apologies. Pushed correct version. |
Still not right, you've not included the actual test file, did you forget to |
470c3db
to
0456493
Compare
0456493
to
df43d2d
Compare
3a5bc41
to
ea2c03a
Compare
ea2c03a
to
3c665ce
Compare
I do want to mention that there are other I also want to write tests for |
This PR has served its purpose. When adding Unit Tests to #85390 to demonstrate I'd fixed the problem, I transferred the Unit Tests from this PR to that one. Thanks @AThousandShips for ensuring this code was in good condition. The code is now in the engine so this specific PR no longer has a purpose. |
Added Unit Test for the UndoRedo system.
This one tests basic functionality and should pass fine.
I'm getting a warning about "ObjectDB instances leaked at exit", but I get the exact same error when running "test_object" (which I used for help with some of the code I wrote) and I double checked my memory allocation so I'm not sure where this is coming from.
Edit: Mentioning #43440 as it's a unit test.