Multiple fixes for compressed meshes #88738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
bug
topic:rendering
topic:import
regression
cherrypick:4.2
…are good enough when using compression
clayjohn
force-pushed
the
mesh_compression-tangents
branch
from
33fc3c2
to
781cd27
Compare
akien-mga
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
I'm not really qualified to do a technical review here, but given the bugs it fixes and Clay's expertise on this area, I'm going to merge so we can get the fixes tested in the next dev snapshot.
Post merge code reviews from rendering/import contributors still welcome :)
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #85406 (fixed by disabling compression when mesh has bogus tangents)
Fixes: #84270 (fixed by disabling compression when we generate bogus tangents because the mesh has bogus UVs)
Fixes: #83345
Fixes: #88619 (fixed by avoiding singularity when generating tangents and normal is exactly (0,1,0)
There are two different fixes here:
When generating dummy tangents from normals, there is a singularity when the normal is exactly (0, 1, 0). In that case we generate bad tangents. So we avoid that by using the normal vector and scrambling the channels to generate the tangent vector. This works in all cases except for when normal is (0,0,0).
When users import bogus meshes the normal/tangent compression fails. It requires that both normals and tangents are valid and are actually perpendicular to each other. Since it is difficult to discover the "force disable compression option", we just detect these cases and silently force disable compression for the user.