Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-4.3 Editor theme color names for compatibility #89302

Merged
merged 1 commit into from
Jun 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions editor/themes/editor_theme_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ void EditorThemeManager::_create_shared_styles(const Ref<EditorTheme> &p_theme,
p_theme->set_color("success_color", EditorStringName(Editor), p_config.success_color);
p_theme->set_color("warning_color", EditorStringName(Editor), p_config.warning_color);
p_theme->set_color("error_color", EditorStringName(Editor), p_config.error_color);
#ifndef DISABLE_DEPRECATED // Used before 4.3.
p_theme->set_color("disabled_highlight_color", EditorStringName(Editor), p_config.highlight_disabled_color);
#endif

// Only used when the Draw Extra Borders editor setting is enabled.
p_config.extra_border_color_1 = Color(0.5, 0.5, 0.5);
Expand Down Expand Up @@ -475,6 +478,12 @@ void EditorThemeManager::_create_shared_styles(const Ref<EditorTheme> &p_theme,
p_theme->set_color("font_readonly_color", EditorStringName(Editor), p_config.font_readonly_color);
p_theme->set_color("font_placeholder_color", EditorStringName(Editor), p_config.font_placeholder_color);
p_theme->set_color("font_outline_color", EditorStringName(Editor), p_config.font_outline_color);
#ifndef DISABLE_DEPRECATED // Used before 4.3.
p_theme->set_color("readonly_font_color", EditorStringName(Editor), p_config.font_readonly_color);
p_theme->set_color("disabled_font_color", EditorStringName(Editor), p_config.font_disabled_color);
p_theme->set_color("readonly_color", EditorStringName(Editor), p_config.font_readonly_color);
p_theme->set_color("highlighted_font_color", EditorStringName(Editor), p_config.font_hover_color); // Closest equivalent.
#endif

// Icon colors.

Expand Down Expand Up @@ -2056,6 +2065,9 @@ void EditorThemeManager::_populate_editor_styles(const Ref<EditorTheme> &p_theme
p_theme->set_color("prop_category", EditorStringName(Editor), prop_category_color);
p_theme->set_color("prop_section", EditorStringName(Editor), prop_section_color);
p_theme->set_color("prop_subsection", EditorStringName(Editor), prop_subsection_color);
#ifndef DISABLE_DEPRECATED // Used before 4.3.
p_theme->set_color("property_color", EditorStringName(Editor), prop_category_color);
#endif

// EditorInspectorCategory.

Expand Down
Loading