Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize rendering_device _add_dependency and _free_dependencies #90010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize rendering_device _add_dependency and _free_dependencies #90010

wants to merge 1 commit into from
+1 −11

Conversation

Nazarwadim
Copy link
Contributor

@Nazarwadim Nazarwadim commented Mar 29, 2024 •
edited

I removed unnecessary has checks that slow down _add_dependency and _free_dependencies.

@Nazarwadim Nazarwadim requested a review from a team as a code owner March 29, 2024 09:12
@AThousandShips AThousandShips added this to the 4.x milestone Mar 29, 2024
@Nazarwadim Nazarwadim changed the title Optimize rendering_device _add_dependency Optimize rendering_device _add_dependency and _free_dependencies Mar 31, 2024
@clayjohn
Copy link
Member

clayjohn commented Apr 2, 2024

Can you add a little bit more information about why this checks are not needed anymore?

@Nazarwadim
Copy link
Contributor Author

Nazarwadim commented Apr 3, 2024 •
edited

Can you add a little bit more information about why this checks are not needed anymore?

In the _add_dependency, the [] operator automatically adds a new element. erase also checks if a key exists in the table.

@Nazarwadim Nazarwadim force-pushed the render_dependency_optimisation branch from 5857d42 to b2a1d75 Compare April 4, 2024 12:23
@Nazarwadim Nazarwadim force-pushed the render_dependency_optimisation branch from b2a1d75 to a8944b8 Compare May 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper left review comments

@AThousandShips AThousandShips AThousandShips left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement performance topic:rendering
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nazarwadim @clayjohn @RandomShaper @AThousandShips