Change pre-commit entry exe from python3 to python. #90634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
bruvzg
reviewed
Apr 13, 2024
| @@ -27,7 +27,7 @@ repos: | |||
| hooks: | |||
| - id: make-rst | |||
| name: make-rst | |||
| entry: python3 doc/tools/make_rst.py doc/classes modules platform --dry-run --color | |||
There was a problem hiding this comment.
This won't work on stock macOS, since only python3 is part of the default installation (homebrew and similar package managers usually have python symlink as well).
|
At the risk of being annoying, I feel like this is something that should be solved in documentation, not the code. It is possible to solve this issue by creating various workarounds on the users system. A quick web search brought me a few Stack Exchange answers. If it helps, I am willing to test and compile some of these solutions into documentation somewhere. |
|
I think that's a good fallback if there turns out not to be a good scripting solution. |
This was referenced May 30, 2024
|
Superseded by #92697. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Windows 10 desktop, pre-commit was unable to find my Python installation because it looked for
python3instead ofpython. Changing the entry point in.pre-commit-config.yamlfrompython3topythonfixed the problem for me. I'm not sure if this is the best solution for other platforms and setups, so it would be great of others could test this change on their setups.