Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled files in FileDialog using the wrong color #91281

Merged

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented Apr 28, 2024

Fixes the wrong color being applied to disabled files in the FileDialog (most notably when using directory mode), rendering their filenames invisible in light mode. I guess at some the name of it got changed (it's in the 3_to_4 migration file) but not in the theme manager.

Before:
image

After:
image

@ckaiser ckaiser requested review from a team as code owners April 28, 2024 16:15
@Calinou Calinou added bug topic:gui cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Apr 28, 2024
@Calinou Calinou added this to the 4.3 milestone Apr 28, 2024
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have ThemeDB we could run some validation for default themes 🤔

@akien-mga akien-mga merged commit 394941c into godotengine:master May 6, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants