Fix export dialog sizing issue on small devices #91291
Open
+42
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another thing that could be scrollable is error list. It can get quite lengthy 🤔 EDIT: EDIT2: |
|
How do I compile this to an apk so i can use it? |
Fixes godotengine#73130 - Update the min height from `700` to `500` to match the editor's min height of `600` - Wrap the sections of the `TabContainer` within a `ScrollContainer`. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.
m4gr3d
force-pushed
the
fix_unreachable_export_button_android_editor
branch
from
401e1d1
to
f0f98ff
Compare
|
The errors are not visible at all now 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73130
700to500to match the editor's min height of600TabContainerwithin aScrollContainer. This prevents the export dialog from trying to resize to fit the tallest of those sections, and make them accessible on small screen devices.