CI: Speedup pre-commit static check
#91417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
May 1, 2024
There was a problem hiding this comment.
Makes sense for now, but actually the env.CHANGED_FILES system is pretty hacky and something I'd be happy to remove eventually.
It seems to me like pre-commit has features to properly assess whether the actual files modified locally should be a match for each check, so we may want to look into this to optimize further, especially for running the checks locally.
akien-mga
changed the title
pre-commit static checkpre-commit static check
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
pre-commitwill always attempt to check every single file in the repo, which is relatively slow for most of the included checks and absurdly slow (multiple minutes) fordotnet-format. This PR rectifies this by overriding the defaultextra_argsin two ways: specifying the actual changed files we currently store inenv.CHANGED_FILES& making the output verbose for logging convenience. This speeds up the entire static check action to under a minute!