Compare binary size with latest master build on CI

[fire]

This makes it easier to track binary size regressions, as you no longer have to build the editor and/or export templates locally to do so.

@Calinou Can you link the proposal number for your pr?

• Copy the correct numbers for the hard coded values

[Calinou]

I don't think comparing the binary size with hardcoded sizes is the right approach. I want to see on CI if the PR's build is larger than the latest successful master build on CI, disregarding official releases. We can't use official releases as a basis here, as they're built with different SCons options that lead to much smaller binaries. (They're also built on a different toolchain, which will also result in different binary sizes.)

@Calinou Can you link the proposal number for your pr?

I've opened a proposal to detail the intent of this feature: godotengine/godot-proposals#9705

[fire]

I disagree, we can use the data from for example github actions' 4.2 branch. The idea is that the hardcoded values don't change every commit.

[Calinou]

I disagree, we can use the data from for example github actions' 4.2 branch. The idea is that the hardcoded values don't change every commit.

If we do this, then we don't know anymore if a PR is actually helping reduce Godot's binary size, or is increasing it.

For example:

• 4.2 branch's latest build is 33,000,000 bytes.
• master branch's latest build is 34,000,000 bytes.
• PR X decreases binary size by 40,000 bytes over master. Compared to 4.2, PR X appears 960,000 bytes larger.
• PR Y increases binary size by 1,500 bytes over master. Compared to 4.2, PR Y appears 998,500 bytes larger.

Both PRs appear to result in a huge binary size increase, but one is actually doing a great job at reducing binary size compared to the status quo (master), while the other isn't.

[fire]

Maybe we can store the last build size on cache?

[Calinou]

Maybe we can store the last build size on cache?

We could have a dedicated artifact for this if we really want to avoid downloading previous builds, but I don't think that's a big issue. Make sure to run strip on the binaries beforehand before uploading their size somewhere though.

[fire]

This is stuck looking for a way to determine "last" logical commit and downloadd, executing it to calculate binary size.