SCons: Process platform-specific flags earlier #91791
Merged
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:buildsystem
needs testing
cherrypick:3.x
akien-mga
force-pushed
the
scons-process-platform-flags-early
branch
from
3702109
to
b439234
Compare
|
Seems to break some stuff: |
|
Related (probably supersedes it): |
akien-mga
force-pushed
the
scons-process-platform-flags-early
branch
from
b439234
to
0eae79d
Compare
Doesn't supersede it yet, but #91794 should. |
akien-mga
force-pushed
the
scons-process-platform-flags-early
branch
2 times, most recently
from
6e4be05
to
c794d7e
Compare
akien-mga
force-pushed
the
scons-process-platform-flags-early
branch
from
c794d7e
to
aa73836
Compare
Some of the logic in SCons depends on flags that get overridden in the platform-specific `detect.py`, so it needs to be processed first. For example the Android/iOS/Web platforms override the default `target` to `template_debug`, but this was processed too late so e.g. the logic that sets `env.editor_build` would set it to true due to the default `target` value in the environment being `editor`.
akien-mga
force-pushed
the
scons-process-platform-flags-early
branch
from
aa73836
to
37cf266
Compare
|
Rebased after #92124. |
Repiteo
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the logic in SCons depends on flags that get overridden in the platform-specific
detect.py, so it needs to be processed first.For example the Android/iOS/Web platforms override the default
targettotemplate_debug, but this was processed too late so e.g. the logic that setsenv.editor_buildwould set it to true due to the defaulttargetvalue in the environment beingeditor.