Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Ensure font image rows/columns are positive #91829

Merged
merged 1 commit into from
May 13, 2024

Conversation

alesliehughes
Copy link
Contributor

Add a check on the import for valid Rows/Columns.
Add some restrictions to the GUI to disallow values <= 0.

Fixes #91812

@alesliehughes alesliehughes requested a review from a team as a code owner May 11, 2024 09:49
@akien-mga akien-mga added this to the 4.3 milestone May 11, 2024
@akien-mga akien-mga requested a review from bruvzg May 11, 2024 09:51
@AThousandShips AThousandShips changed the title Editor: Disallow font image rows/columns to be zero or less Editor: Ensure font image rows/columns are positive May 11, 2024
@AThousandShips

This comment was marked as resolved.

@alesliehughes
Copy link
Contributor Author

Pushed the correct change this time.

Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the code style that needs fixing

@akien-mga akien-mga merged commit ad4e9d2 into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when importing image as FontData if setting rows to 0
4 participants