Fix script properties being lost and prevent node reference corruption upon scene reimport #92279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire
reviewed
May 24, 2024
There was a problem hiding this comment.
I tested https://github.com/godotengine/godot/files/15415243/reimport_test.zip.
On 4.3 and this pr it keeps the last value
Screen.Recording.2024-05-23.at.7.23.22.PM.mov
On 4.2 it resets on reimport
Screen.Recording.2024-05-23.at.7.20.01.PM.mov
Will do more testing.
fire
approved these changes
May 24, 2024
There was a problem hiding this comment.
I tested the broken cases. See video. It seems to resolve property reload bugs.
Didn't see anything obviously problematic.
The last attempt to introduce this fix created a signal. In this bugfix pull request we use _nodes_scene_reimported as the callback as a replacement.
|
@lyuma I expect this to solve your common case of "click on the skeleton" and click reimport to see Godot Engine crash bug. |
SaracenOne
force-pushed
the
scene_reload_crashfix_2
branch
2 times, most recently
from
f049cbe
to
f83bdeb
Compare
AThousandShips
approved these changes
May 27, 2024
SaracenOne
force-pushed
the
scene_reload_crashfix_2
branch
from
f83bdeb
to
686a167
Compare
akien-mga
reviewed
May 28, 2024
* The reimported instance attempt to preserve ownerless nodes. * A recursive function call to '_nodes_scene_reimported' so these can be recreated if required. * Clears instance scene_state on new instantiated replacement nodes.
fire
force-pushed
the
scene_reload_crashfix_2
branch
from
686a167
to
97d2730
Compare
|
Preserves exported script variables Prevents corruption of direct node references.
fire
force-pushed
the
scene_reload_crashfix_2
branch
from
892786c
to
e57312d
Compare
|
Thanks @fire, I was a bit confused how the CoreStringNames API was meant to be used. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands and depends upon the previous PR (#92182) to fix further bugs in the hot scene reloader. It now prevents script properties on reimported nodes from getting lost, and prevents node reference properties referencing nodes which get replaced by the reimport system from being retained, preventing several cases which can cause editor crashes.