Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a string replace method to handle multiple search keys efficiently. #92433

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add a string replace method to handle multiple search keys efficiently. #92433

wants to merge 7 commits into from

Commits on May 27, 2024

  1. Add a string replace method to handle multiple search keys efficiently. 

    There are multiple places where we want to replace multiple characters or strings
with one character (e.g. cleaning up paths), and calling replace for every source
string is wasteful, we can do it all in one go.
    @shana
    shana committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5235392 View commit details
    Browse the repository at this point in the history

  2. Fix off-by-one error and add a string replace test

    @shana
    shana committed May 27, 2024
    Configuration menu
    Copy the full SHA
    76b6e87 View commit details
    Browse the repository at this point in the history

  3. Make string vectors to replace static so we're not allocating every time

    @shana
    shana committed May 27, 2024
    Configuration menu
    Copy the full SHA
    60c35c4 View commit details
    Browse the repository at this point in the history

  4. Expose replace(Vector<String>, String) to script as replace_all

    @shana
    shana committed May 27, 2024
    Configuration menu
    Copy the full SHA
    44235e5 View commit details
    Browse the repository at this point in the history

  5. Missed a spot

    @shana
    shana committed May 27, 2024
    Configuration menu
    Copy the full SHA
    3afcedf View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Make sure empty key strings are handled correctly. 

    Co-authored-by: Aaron Pagano <136198872+aaronp64@users.noreply.github.com>
    @shana @aaronp64
    shana and aaronp64 authored May 28, 2024
    Configuration menu
    Copy the full SHA
    ccb9bd4 View commit details
    Browse the repository at this point in the history

  2. Update ustring.cpp 

    Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
    @shana @AThousandShips
    shana and AThousandShips authored May 28, 2024
    Configuration menu
    Copy the full SHA
    95d3161 View commit details
    Browse the repository at this point in the history