Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Physics Interpolation - Fix 2D skinning #93309

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

lawnjelly
Copy link
Member

2D skinning required the interpolated skeleton base transform to be updated when using interpolation.

Fixes #92872

Notes

  • The MRP needs to set interpolation to on for the skeleton for this to work (this turns on the machinery).
  • The skeleton processing throttles off automatically when hidden.

@lawnjelly lawnjelly added this to the 3.6 milestone Jun 18, 2024
@lawnjelly lawnjelly requested a review from a team as a code owner June 18, 2024 13:53
2D skinning required the interpolated skeleton base transform to be updated when using interpolation.
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Behavior is still correct when physics interpolation is disabled.

Code looks good to me.

Before

skeleton_3.x_master.mp4

After

skeleton_3.x_pr.mp4

@lawnjelly lawnjelly merged commit 12781e4 into godotengine:3.x Jun 19, 2024
14 checks passed
@lawnjelly lawnjelly deleted the fti_skinning branch June 19, 2024 05:50
@lawnjelly
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants