Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch of orphan StringName errors at ProjectSettings/Editor exit #93888

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 3, 2024

This fixes all the orphan node errors on exit of Project Settings dialog, and at the editor exit from an empty project the only error still exist is:

изображение

(I did not find a source yet)

Note: This target to (close) #92726, but because of the single orphan Node string it is still incomplete...

@Chaosus Chaosus requested review from a team as code owners July 3, 2024 07:48
@Chaosus Chaosus added this to the 4.3 milestone Jul 3, 2024
@Chaosus Chaosus requested a review from KoBeWi July 3, 2024 07:52
@Chaosus Chaosus force-pushed the fix_orphan_strings branch 3 times, most recently from bb5f376 to 5286a56 Compare July 3, 2024 08:21
@akien-mga akien-mga merged commit 6da4b72 into godotengine:master Jul 10, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the fix_orphan_strings branch July 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants