Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple GCC 14 -Wmaybe-uninitialized warnings #94133

Merged

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jul 9, 2024

Started getting these warnings today on Fedora 40 with a dev_build=yes scu_build=yes.

The PackedPeerUDP one sounds like a GCC false positive, so alternative we could silence it... but the quick workaround of initing the array may not be too terrible?
Edit: Alvin on RC pointed out this may be this GCC regression indeed: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107751

@akien-mga akien-mga added enhancement topic:core topic:buildsystem cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 9, 2024
@akien-mga akien-mga added this to the 4.3 milestone Jul 9, 2024
@akien-mga akien-mga requested review from a team as code owners July 9, 2024 14:38
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple enough

@akien-mga akien-mga merged commit 34d4c91 into godotengine:master Jul 10, 2024
18 checks passed
@akien-mga akien-mga deleted the fix-gcc14-Wmaybe-uninitialized branch July 10, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release enhancement topic:buildsystem topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants